Attaching darcs patches (was: Cygwin portability patch)

[Brian Rice]

Okay, but vm.c is generated from Slate source. :) Also, patches need to 
come from repositories that use "main" as their source... I can see 
that I need to make a big prominent page explaining how patches need to 
be submitted. Here's a first cut: http://slate.tunes.org:8080/wiki/72 . 
Please edit as you see fit, or suggest more prominence for the page; 
it's listed from the wiki front-page for now.

I've patched the source to do the equivalent, and pushed it into main; 
it's not tested fully, however. Yell and wave your hands if there's a 
problem, please.

Thanks!

On Apr 28, 2005, at 6:20 PM, David Hopwood wrote:

> Brian Rice wrote:
>> On Apr 28, 2005, at 3:31 PM, David Hopwood wrote:
>>> Brian Rice wrote:
>>>
>>>> I re-constituted the patch and applied it in the main repository. 
>>>> Please do not send darcs patches inline (use darcs send -o filename 
>>>> and attach it manually), as they never work for some encoding 
>>>> reason I have not determined.
>>>
>>> That's what I did ("darcs send -o cygwin.patch"). If it didn't apply 
>>> as-is, that can't be the reason.
>>
>> Your attachment showed up as an inline attachment, which is the same 
>> symptom I saw for other failed patches. Don't attach them inline.
>
> Oh, you mean "Content-Disposition: inline". Thunderbird seems not to
> have any option to override that for attachments that look like text.
> On closer examination the problem may be something to do with
> canonicalization of line endings.
>
> I've reattached the vm.c warning fix mentioned in my other email
> in a .zip file; I think that should solve the problem.
>
> -- 
> David Hopwood <david.nospam.hopwood at blueyonder.co.uk>
> <vm-warning.zip>
--
Brian T. Rice
LOGOS Research and Development
http://tunes.org/~water/