[FIX] UI Bitrot

[Brian Rice]

On Apr 11, 2006, at 4:22 PM, Todd Fleming wrote:

> This patch fixes several UI bugs; it runs again.
>
> Note: Do *not* apply to patch that Timmy posted today; it is based  
> on an unfortunate misunderstanding caused by Bug 2.
>
> Bug 1
> =====
> src/ui/graphics.slate is in AutoLoad, which broke the instructions
> in src/ui/README.  "load: 'src/ui/graphics.slate'" caused the file  
> to load twice.  This is why #parents: misbehaved and the call to  
> #text: failed.
>
> Bug 2
> =====
> Fortunately I keep old sources around to compare with.   
> Unfortunately someone made wholesale cosmetic changes to
> plugins/sdl-windows/windows.slate which made it difficult to compare.
> One of those cosmetic changes introduced a bug.
>
> Someone changed:
>   Windows eventTable add:
>       (each key) ->
>       (Windows EventTableEntry
>           newPrototype: (events atSlotNamed: (each value at: 0))
>           constructors: (each value at: 1))].
>
> To:
>   Windows eventTable at: each key put:
>     (Windows EventTableEntry
>        newPrototype: (events atSlotNamed: each value first)
>        constructors: each value first)].
>
> This should be:
>   Windows eventTable at: each key put:
>     (Windows EventTableEntry
>        newPrototype: (events atSlotNamed: each value first)
>        constructors: each value second)].
>
> This caused constructors to be initialized with a (wrong) symbol
> instead of a list.

Erg. That would be my fault. Sorry about that. I've applied the patch  
and pushed it into the site repositories - thanks.

--
-Brian
http://tunes.org/~water/brice.vcf

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
Url : /archives/slate/attachments/20060411/68ed630f/PGP.pgp